[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion |
Date: |
Wed, 23 May 2012 23:34:34 -0300 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
From: Jan Kiszka <address@hidden>
tb_invalidate_phys_addr has to called with the exact physical address of
the breakpoint we add/remove, not just the page's base address.
Otherwise we easily fail to flush the right TB.
Regression of 1e7855a558.
Reported-by: TeLeMan <address@hidden>
Signed-off-by: Jan Kiszka <address@hidden>
---
exec.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/exec.c b/exec.c
index a0494c7..efa1345 100644
--- a/exec.c
+++ b/exec.c
@@ -1492,7 +1492,8 @@ void tb_invalidate_phys_addr(target_phys_addr_t addr)
static void breakpoint_invalidate(CPUArchState *env, target_ulong pc)
{
- tb_invalidate_phys_addr(cpu_get_phys_page_debug(env, pc));
+ tb_invalidate_phys_addr(cpu_get_phys_page_debug(env, pc) +
+ (pc & ~TARGET_PAGE_MASK));
}
#endif
#endif /* TARGET_HAS_ICE */
--
1.7.3.4
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion,
Jan Kiszka <=
- Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion, Jan Kiszka, 2012/05/23
- Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion, Max Filippov, 2012/05/24
- Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion, Jan Kiszka, 2012/05/24
- Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion, Max Filippov, 2012/05/24
- Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion, Jan Kiszka, 2012/05/24
- Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion, Max Filippov, 2012/05/24
- Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion, Jan Kiszka, 2012/05/24
- Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion, Max Filippov, 2012/05/24
- Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion, Jan Kiszka, 2012/05/24
- Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion, Max Filippov, 2012/05/24