[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 2/2] PCI: acpiphp: remove all functions in sl
From: |
Yinghai Lu |
Subject: |
Re: [Qemu-devel] [PATCH v7 2/2] PCI: acpiphp: remove all functions in slot, even without ACPI _EJx |
Date: |
Tue, 22 May 2012 22:29:04 -0700 |
On Tue, May 22, 2012 at 10:15 PM, Amos Kong <address@hidden> wrote:
> Attached the v7, test passed.
would be better to have break...
+static struct pci_dev *dev_in_slot(struct acpiphp_slot *slot)
+{
+ struct pci_bus *bus = slot->bridge->pci_bus;
+ struct pci_dev *dev;
+ int ret = NULL;
+
+ down_read(&pci_bus_sem);
+ list_for_each_entry(dev, &bus->devices, bus_list)
+ if (PCI_SLOT(dev->devfn) == slot->device)
+ ret = pci_dev_get(dev);
+ up_read(&pci_bus_sem);
+
+ return ret;
+}
===>
+static struct pci_dev *dev_in_slot(struct acpiphp_slot *slot)
+{
+ struct pci_bus *bus = slot->bridge->pci_bus;
+ struct pci_dev *dev;
+ int ret = NULL;
+
+ down_read(&pci_bus_sem);
+ list_for_each_entry(dev, &bus->devices, bus_list)
+ if (PCI_SLOT(dev->devfn) == slot->device) {
+ ret = pci_dev_get(dev);
+ break;
+ }
+ up_read(&pci_bus_sem);
+
+ return ret;
+}
- [Qemu-devel] [PATCH v6 0/2] PCI: acpiphp: remove multifunction devices, Bjorn Helgaas, 2012/05/23
- [Qemu-devel] [PATCH v6 1/2] PCI: acpiphp: fix function 0 leak when disabling a slot, Bjorn Helgaas, 2012/05/23
- [Qemu-devel] [PATCH v6 2/2] PCI: acpiphp: remove all functions in slot, even without ACPI _EJx, Bjorn Helgaas, 2012/05/23
- Re: [Qemu-devel] [PATCH v6 2/2] PCI: acpiphp: remove all functions in slot, even without ACPI _EJx, Yinghai Lu, 2012/05/23
- [Qemu-devel] [PATCH v7 2/2] PCI: acpiphp: remove all functions in slot, even without ACPI _EJx, Amos Kong, 2012/05/23
- Re: [Qemu-devel] [PATCH v7 2/2] PCI: acpiphp: remove all functions in slot, even without ACPI _EJx,
Yinghai Lu <=
- [Qemu-devel] [PATCH v8 2/2] PCI: acpiphp: remove all functions in slot, even without ACPI _EJx, Amos Kong, 2012/05/23
- Re: [Qemu-devel] [PATCH v8 2/2] PCI: acpiphp: remove all functions in slot, even without ACPI _EJx, Bjorn Helgaas, 2012/05/24