[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Prevent disk data loss when closing qemu
From: |
Pavel Dovgaluk |
Subject: |
Re: [Qemu-devel] [PATCH] Prevent disk data loss when closing qemu |
Date: |
Wed, 23 May 2012 10:48:57 +0400 |
> From: Paolo Bonzini [mailto:address@hidden On Behalf Of Paolo Bonzini
> Il 22/05/2012 10:51, Kevin Wolf ha scritto:
> > Am 16.05.2012 12:16, schrieb Pavel Dovgaluk:
> >> I use qemu under Windows and it has two windows when executes - console
> >> and SDL ones.
> >> When I close SDL window main loop function terminates correctly, and when
> >> I close
> >> console window to terminate qemu then the code after main loop is not
> >> executed.
> >
> > Is there no way to catch this case and use the regular shutdown
> > mechanism there as well?
> >
> > I'm not against your patch and it's probably 1.1 material, but there may
> > be more shutdown logic that we're missing if you close the console window.
>
> Looks like qemu_ctrl_handler (in os-win32.c) needs to do something like
> termsig_handler (in os-posix.c) instead of a plain exit.
I tried to call qemu_system_shutdown_request() instead of exit() there, but
Windows kills qemu
before it finishes cleanup work.
Pavel Dovgaluk