[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ISCSI: We need to call qemu_notify_event() ever
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] ISCSI: We need to call qemu_notify_event() everytime we update which events we need to be notified for. |
Date: |
Tue, 22 May 2012 14:13:40 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
Il 22/05/2012 11:56, Ronnie Sahlberg ha scritto:
> Otherwise, If we add an event for -is-writeable but the socket is already
> writeable there may be a short delay before the event callback is actually
> triggered.
>
> Those delays would in particular hurt performance during BIOS boot and when
> the GRUB bootloader reads the kernel and initrd.
>
> Signed-off-by: Ronnie Sahlberg <address@hidden>
> ---
> block/iscsi.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index d37c4ee..f956824 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -109,6 +109,13 @@ iscsi_set_events(IscsiLun *iscsilun)
> (iscsi_which_events(iscsi) & POLLOUT)
> ? iscsi_process_write : NULL,
> iscsi_process_flush, iscsilun);
> +
> + /* If we just added the event for writeable we must call
> + and the socket is already writeable the callback might
> + not be invoked until after a short delay unless we call
> + qemu_notify_event().
> + */
> + qemu_notify_event();
> }
>
> static void
Thanks, applied to SCSI branch for 1.1.
Paolo