[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix size checking in load_image_targphys to acc
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCH] Fix size checking in load_image_targphys to accept max_size > INT_MAX |
Date: |
Wed, 16 May 2012 12:29:35 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
On 03/05/12 16:33, Peter Maydell wrote:
> On 3 May 2012 15:27, Christian Borntraeger <address@hidden> wrote:
>> commit 17df768c1e4580f03301d18ea938d3557d441911
>> load_image_targphys() should enforce the max size
>>
>> caused some problems with external kernel and specific ram sizes on s390:
>>
>> We load the external kernel with
>>
>> [...]
>> kernel_size = load_image_targphys(kernel_filename, 0, ram_size);
>> [...]
>>
>> Since load_image_targphys is declared as taking an int for max_sz, this will
>> fail for ram sizes > INT_MAX.
>> Lets change the max_sz parameter to a uint64_t.
>>
>> Signed-off-by: Christian Borntraeger <address@hidden>
>
> A patch equivalent to this has already been submitted:
> http://patchwork.ozlabs.org/patch/146165/
> We should be applying that one, it has already been reviewed.
>
> Anthony?
Anthony,
can you apply the patchwork patch for 1.1?
Christian
- [Qemu-devel] S390: file size checking in load_image_targphys and certain ram sizes, Christian Borntraeger, 2012/05/03
- Re: [Qemu-devel] S390: file size checking in load_image_targphys and certain ram sizes, Alexander Graf, 2012/05/03
- [Qemu-devel] [PATCH] Fix size checking in load_image_targphys to accept max_size > INT_MAX, Christian Borntraeger, 2012/05/03
- Re: [Qemu-devel] [PATCH] Fix size checking in load_image_targphys to accept max_size > INT_MAX, Peter Maydell, 2012/05/03
- Re: [Qemu-devel] [PATCH] Fix size checking in load_image_targphys to accept max_size > INT_MAX, Christian Borntraeger, 2012/05/04
- Re: [Qemu-devel] [PATCH] Fix size checking in load_image_targphys to accept max_size > INT_MAX, Christian Borntraeger, 2012/05/09
- Re: [Qemu-devel] [PATCH] Fix size checking in load_image_targphys to accept max_size > INT_MAX,
Christian Borntraeger <=
- Re: [Qemu-devel] [PATCH] Fix size checking in load_image_targphys to accept max_size > INT_MAX, Alexander Graf, 2012/05/17
- Re: [Qemu-devel] [PATCH] Fix size checking in load_image_targphys to accept max_size > INT_MAX, Anthony Liguori, 2012/05/17