Re: [Qemu-devel] [PATCH] RTL8139 hotplug is broken on windows 2008 sp2.

[Andreas Färber]

Am 09.05.2012 23:00, schrieb Alexander Graf:
> 
> On 09.05.2012, at 22:20, Andreas Färber wrote:
> 
>> Am 14.02.2012 04:10, schrieb address@hidden:
>>> From: Bo Yang <address@hidden>
>>>
>>> Windows 2008 sp2 tries to read mac address from phys
>>> and then write the read value into it. This patch
>>> is a workaround for the issue.
>>>
>>> Signed-off-by: Bo Yang <address@hidden>
>>> ---
>>> hw/rtl8139.c |    2 ++
>>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> Ping! Who feels responsible for reviewing this?
>> It would be a candidate for 1.1 and 0.15.x (BNC#722643).
>>
>> Only issue I see is that the subject could be improved (saying what it
>> does rather than what was broken before, e.g. "rtl8139: Init phys with
>> MAC address").
> 
> I thought the real bug was that the reset function didn't get called?

That was for the e1000 that I was working on (BNC#722958). I believe Bo
tested the combination of both patches?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg