Re: [Qemu-devel] get_maintainer.pl prints invalid Cc: [Re: Fwd: Undelivered Mail Returned to Sender

[Jim Meyering]

Andreas Färber wrote:
> Am 09.05.2012 14:38, schrieb Jim Meyering:
>> Alexander Graf wrote:
>>> Hrm :)
>>
>> That appears to be due to scripts/get_maintainer.pl not sanitizing
>> its output addresses.  E.g., using my 06/22 patch, I get this bogus Cc:
>>
>>     $ scripts/get_maintainer.pl 0006-*|grep open
>>     address@hidden (open list:POSIX)
>
> What's bogus about that? The email address is that of our mailing list,
> we use it for subsystems where we don't have a particular maintainer. L:
> gets translated to "open list" and the MAINTAINERS section is apparently
> titled "POSIX". Comments to be ignored by MTAs can be indicated in
> parenthesis as far as I remember RFC822, so it seems semantically and
> syntactically correct. What would need to be sanitized?

You're right.  The parenthesized quantity should be ignored.

> I have once seen that break when replying to messages though. Maybe when
> the list of CCs gets broken into multiple lines? That would be a
> git-send-email or MUA problem then though.

The Cc: addresses were added one per line.
For the record, here's the head of the file that caused the trouble
(it was one of the 22 arguments to git-send-email):

  From 999cf5c62ec798b0698970a0bad05b578e3bee3c Mon Sep 17 00:00:00 2001
  From: Jim Meyering <address@hidden>
  Date: Mon, 7 May 2012 17:06:18 +0200
  Cc: Alexander Graf <address@hidden>
  Cc: Avi Kivity <address@hidden>
  Cc: Marcelo Tosatti <address@hidden>
  Cc: address@hidden (open list:PowerPC)
  Cc: address@hidden (open list:Overall)

Here's the command I invoked on a debian-unstable system using
git 1.7.10 and postfix as the MTA:

  git send-email --compose --suppress-from \
    --from='Jim Meyering <address@hidden>' address@hidden 00*