[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-arm: When setting FPSCR.QC, don't clear
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-arm: When setting FPSCR.QC, don't clear other FPSCR bits |
|
Date: |
Tue, 8 May 2012 16:01:41 +0100 |
On 7 May 2012 03:45, Matt Craighead <address@hidden> wrote:
> diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c
> -#define SET_QC() env->vfp.xregs[ARM_VFP_FPSCR] = CPSR_Q
> +#define SET_QC() env->vfp.xregs[ARM_VFP_FPSCR] |= CPSR_Q
Bug reproduced, fix confirmed,
Reviewed-by: Peter Maydell <address@hidden>
This bug has actually been in the code since 2008...
As a trivial and obvious patch I think I'll put it into a pullreq
for 1.1.
-- PMM