Re: [Qemu-devel] [PATCH] Fix SPI SD emulation

[Igor Mitsyanko]

On 29.04.2012 6:31 PM, Paul Brook wrote:
> > > -    sd_adtc, sd_none, sd_none, sd_none, sd_none, sd_none, sd_none,
> > > +    sd_adtc, sd_none, sd_bc,   sd_bc,   sd_none, sd_none,
> >
> > sd_bcr? not that it really matters though
>
> Err, probably.
>
> > > +    case 58:    /* CMD58: READ_OCR */
> > > +        if (!sd->spi) {
> > > +            goto bad_cmd;
> > > +        }
> > > +        switch (sd->state) {
> > > +        case sd_idle_state:
> > > +        case sd_transfer_state:
> > > +            return sd_r3;
> >
> > If this command could be issued in transfer state maybe in addition to
> > IDLE_STATE you also need to set other bits (ADDRESS_ERROR,
> > COM_CRC_ERROR, ILLEGAL_COMMAND, ERASE_SEQ_ERROR) in MSB of R3 response?
>
> In theory, yes.  I was thinking of a follow-up patch to move the spi status
> byte generation into sd.c.  Maybe I should do that first.

Do you mean the one in ssi-sd.c? That would be nice I think, a bit less 
confusing.