Re: [Qemu-devel] [PATCH] target-ppc: Some support for dumping TLB_EMB TLBs

[Alexander Graf]

On 24.04.2012, at 18:48, François Revol wrote:

> Add mmubooke_dump_mmu().
> 
> TODO: Add printing of individual flags.
> 
> Signed-off-by: François Revol <address@hidden>

address@hidden:/home/agraf/release/qemu> git pw am 'target-ppc: Some support 
for dumping TLB_EMB TLBs'
WARNING: line over 80 characters
#42: FILE: target-ppc/helper.c:1481:
+    cpu_fprintf(f, "Effective          Physical           Size PID   Prot     
Attr\n");

WARNING: braces {} are necessary for all arms of this statement
#64: FILE: target-ppc/helper.c:1503:
+        if (size >= 1024)
[...]
+        else
[...]

WARNING: line over 80 characters
#65: FILE: target-ppc/helper.c:1504:
+            snprintf(size_buff, sizeof(size_buff), "%3" PRId64 "M", size / 
1024);

total: 0 errors, 3 warnings, 61 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
checkpatch failed, still apply? [y|N] 


I'll fix them up this time around, but please run checkpatch next time before 
submitting a patch ;). Also, please think of a nicer commit message next time.

Applied to ppc-next.


Alex