[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 0/5] block: add optional 'speed' parameter to
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH v4 0/5] block: add optional 'speed' parameter to block-stream |
Date: |
Wed, 25 Apr 2012 17:41:23 -0300 |
On Wed, 25 Apr 2012 16:50:59 +0100
Stefan Hajnoczi <address@hidden> wrote:
> Eric Blake raised concerns about the inability to start block jobs with a
> speed
> limit. Current the user needs to follow up the block-stream command with
> block-job-set-speed. There is a window of time while the new block job is
> running but block-job-set-speed has not been processed yet.
>
> This series adds an optional 'speed' parameter to block-stream so streaming
> can
> be started with a speed limit that takes effect immediately.
>
> For consistency it also renames the block-job-set-speed parameter from 'value'
> to 'speed'. This is externally visible, but this API has not been in a QEMU
> release yet so we can still do this.
>
> I considered several other approaches, including adding a
> default_block_job_speed field to BlockDriverState but ultimately the cleanest
> solution is to pass in a speed parameter on job creation. This way we do not
> change semantics of existing commands, we only add an optional parameter. We
> also do not need to add state to BlockDriverState, which is already huge and
> messy.
Applied to the qmp branch, thanks Stefan.
- [Qemu-devel] [PATCH v4 0/5] block: add optional 'speed' parameter to block-stream, Stefan Hajnoczi, 2012/04/25
- [Qemu-devel] [PATCH v4 2/5] block: use Error mechanism instead of -errno for block_job_set_speed(), Stefan Hajnoczi, 2012/04/25
- [Qemu-devel] [PATCH v4 4/5] block: add 'speed' optional parameter to block-stream, Stefan Hajnoczi, 2012/04/25
- [Qemu-devel] [PATCH v4 1/5] block: use Error mechanism instead of -errno for block_job_create(), Stefan Hajnoczi, 2012/04/25
- [Qemu-devel] [PATCH v4 5/5] qemu-iotests: add block-stream speed value test case, Stefan Hajnoczi, 2012/04/25
- [Qemu-devel] [PATCH v4 3/5] block: change block-job-set-speed argument from 'value' to 'speed', Stefan Hajnoczi, 2012/04/25
- Re: [Qemu-devel] [PATCH v4 0/5] block: add optional 'speed' parameter to block-stream,
Luiz Capitulino <=