[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 3/9][SeaBIOS] acpi: generate hotplug memory
From: |
Vasilis Liaskovitis |
Subject: |
Re: [Qemu-devel] [RFC PATCH 3/9][SeaBIOS] acpi: generate hotplug memory devices. |
Date: |
Tue, 24 Apr 2012 10:27:34 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Hi,
On Mon, Apr 23, 2012 at 07:37:51PM -0400, Kevin O'Connor wrote:
> On Thu, Apr 19, 2012 at 04:08:41PM +0200, Vasilis Liaskovitis wrote:
> > The memory device generation is guided by qemu paravirt info. Seabios
> > first uses the info to setup SRAT entries for the hotplug-able memory
> > slots.
> > Afterwards, build_memssdt uses the created SRAT entries to generate
> > appropriate memory device objects. One memory device (and corresponding
> > SRAT
> > entry) is generated for each hotplug-able qemu memslot. Currently no SSDT
> > memory device is created for initial system memory (the method can be
> > generalized to all memory though).
> >
> > Signed-off-by: Vasilis Liaskovitis <address@hidden>
> > ---
> > src/acpi.c | 151
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
> > 1 files changed, 147 insertions(+), 4 deletions(-)
> >
> > diff --git a/src/acpi.c b/src/acpi.c
> > index 30888b9..5580099 100644
> > --- a/src/acpi.c
> > +++ b/src/acpi.c
> > @@ -484,6 +484,131 @@ build_ssdt(void)
> > return ssdt;
> > }
> >
> > +static unsigned char ssdt_mem[] = {
> > + 0x5b,0x82,0x47,0x07,0x4d,0x50,0x41,0x41,
>
> This patch looks like it uses the SSDT generation mechanism that was
> present in SeaBIOS v1.6.3. Since then, however, the runtime AML code
> generation has been improved to be more dynamic. Any runtime
> generated AML code should be updated to use the newer mechanisms.
thanks, I will look into the new mechanism and rewrite.
- Vasilis
- [Qemu-devel] [RFC PATCH 0/9] ACPI memory hotplug, Vasilis Liaskovitis, 2012/04/19
- [Qemu-devel] [RFC PATCH 2/9][SeaBIOS] Implement acpi-dsdt functions for memory hotplug., Vasilis Liaskovitis, 2012/04/19
- [Qemu-devel] [RFC PATCH 3/9][SeaBIOS] acpi: generate hotplug memory devices., Vasilis Liaskovitis, 2012/04/19
- [Qemu-devel] [RFC PATCH 1/9][SeaBIOS] Add SSDT memory device support, Vasilis Liaskovitis, 2012/04/19
- [Qemu-devel] [RFC PATCH 4/9] Implement memslot device abstraction, Vasilis Liaskovitis, 2012/04/19
- [Qemu-devel] [RFC PATCH 5/9] acpi_piix4: Implement memory device hotplug registers, Vasilis Liaskovitis, 2012/04/19
- [Qemu-devel] [RFC PATCH 9/9][SeaBIOS] enable memory devices if e820 entry is present, Vasilis Liaskovitis, 2012/04/19
- [Qemu-devel] [RFC PATCH 8/9] pc: adjust e820 map on hot-add and hot-remove, Vasilis Liaskovitis, 2012/04/19
- [Qemu-devel] [RFC PATCH 6/9] pc: pass paravirt info for hotplug memory slots to BIOS, Vasilis Liaskovitis, 2012/04/19