Re: [Qemu-devel] [PATCH v2 12/14] target-arm: Drop cpu_reset_model_id()

[Peter Maydell]

On 20 April 2012 17:14, Andreas Färber <address@hidden> wrote:
> Am 14.04.2012 18:42, schrieb Peter Maydell:
>>  /* TODO Move contents into arm_cpu_reset() in cpu.c,
>>   *      once cpu_reset_model_id() is eliminated,
>
> ...if you were to drop this comment line it would be cleaner. There is
> no cpu_reset_model_id() any more.

...the whole comment disappears in the next patch.

> Also, can't some CPUID defines already be dropped in this patch, now
> that the switch is gone?

It would be possible, but I didn't really like the approach of
dropping some but not all of them.

-- PMM