[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/15] target-i386: Add property getter for CPU
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 09/15] target-i386: Add property getter for CPU model |
Date: |
Fri, 20 Apr 2012 11:06:20 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120312 Thunderbird/11.0 |
Am 20.04.2012 02:14, schrieb Michael Roth:
> On Wed, Apr 18, 2012 at 01:11:13AM +0200, Andreas Färber wrote:
>> Signed-off-by: Andreas Färber <address@hidden>
>> ---
>> target-i386/cpu.c | 14 +++++++++++++-
>> 1 files changed, 13 insertions(+), 1 deletions(-)
>>
>> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
>> index 21041b5..2beb3ab 100644
>> --- a/target-i386/cpu.c
>> +++ b/target-i386/cpu.c
>> @@ -640,6 +640,18 @@ static void x86_cpuid_version_set_family(Object *obj,
>> Visitor *v, void *opaque,
>> }
>> }
>>
>> +static void x86_cpuid_version_get_model(Object *obj, Visitor *v, void
>> *opaque,
>> + const char *name, Error **errp)
>> +{
>> + X86CPU *cpu = X86_CPU(obj);
>> + CPUX86State *env = &cpu->env;
>> + int64_t value;
>> +
>> + value = (env->cpuid_version >> 4) & 0xf;
>> + value |= (env->cpuid_version >> 16) & 0xf;
>
> I think this needs to be:
>
> value |= ((env->cpuid_version >> 16) & 0xf) << 4;
You're right! Thanks for catching this.
/-F
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH 14/15] target-i386: Prepare "vendor" property for X86CPU, (continued)
- [Qemu-devel] [PATCH 08/15] target-i386: Add property getter for CPU family, Andreas Färber, 2012/04/17
- [Qemu-devel] [PATCH 07/15] target-i386: Add "model-id" property to X86CPU, Andreas Färber, 2012/04/17
- [Qemu-devel] [PATCH 09/15] target-i386: Add property getter for CPU model, Andreas Färber, 2012/04/17
- Re: [Qemu-devel] [PATCH 00/15] QOM'ify x86 CPU, part 2: properties, Eduardo Habkost, 2012/04/19
- Re: [Qemu-devel] [PATCH 00/15] QOM'ify x86 CPU, part 2: properties, Michael Roth, 2012/04/19