Re: [Qemu-devel] [PATCH v9 07/10] Add XBZRLE option to migrate command

[Juan Quintela]

Orit Wasserman <address@hidden> wrote:
> Signed-off-by: Orit Wasserman <address@hidden>
> Signed-off-by: Benoit Hudzia <address@hidden>
> Signed-off-by: Petter Svard <address@hidden>
> Signed-off-by: Aidan Shribman <address@hidden>
> ---
>  hmp-commands.hx  |   20 ++++++++++++--------
>  hmp.c            |    4 +++-
>  migration.c      |    9 +++++++++
>  qapi-schema.json |    2 +-
>  qmp-commands.hx  |    4 +++-
>  5 files changed, 28 insertions(+), 11 deletions(-)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index a6f5a84..a73b538 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -798,23 +798,27 @@ ETEXI
>  
>      {
>          .name       = "migrate",
> -        .args_type  = "detach:-d,blk:-b,inc:-i,uri:s",
> -        .params     = "[-d] [-b] [-i] uri",
> -        .help       = "migrate to URI (using -d to not wait for completion)"
> -                   "\n\t\t\t -b for migration without shared storage with"
> -                   " full copy of disk\n\t\t\t -i for migration without "
> -                   "shared storage with incremental copy of disk "
> -                   "(base image shared between src and destination)",
> +        .args_type  = "detach:-d,blk:-b,inc:-i,xbzrle:-x,uri:s",
> +        .params     = "[-d] [-b] [-i] [-x] uri",
> +        .help       = "migrate to URI"
> +                      "\n\t -d to not wait for completion"
> +                   "\n\t -b for migration without shared storage with"
> +                   " full copy of disk"

There are tabs on that two lines, or only spaces on the next ones, your
choice O:-)

Rest looks ok.

Thanks, Juan.