[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/12 v12] introduce a new monitor command 'dump
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 12/12 v12] introduce a new monitor command 'dump-guest-memory' to dump guest's memory |
Date: |
Wed, 18 Apr 2012 09:35:40 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
On 04/18/2012 03:37 AM, Wen Congyang wrote:
>>> 2. This command doesn't support the fd that is is associated with a pipe,
>>> socket, or FIFO(lseek will fail with such fd).
>>
>> How hard would it be to lift that restriction ? When libvirt does save to
>> file, or core dump these days, we tend to pass a pipe FD to QEMU, which
>> is connected to libvirt's I/O helper process. The reason for this is that
>> it lets us turn on O_DIRECT for the dumped data, which has proved to be
>> quite an important feature for oVirt. So I'd rather like to keep that
>> ability with the new dump command.
>
> The reason is that we will use lseek(fd, ...). If you pass a pipe FD
> to qemu, lseek() will fail. I donot know the note size before we
> write it to the core, so I use lseek()...
The question, then, is why we don't know the note size in advance, and
what it would take to be able to compute it in advance so that the
output file can be written in a single pass without needing lseek().
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 05/12 v12] Add API to get memory mapping, (continued)
- [Qemu-devel] [PATCH 05/12 v12] Add API to get memory mapping, Wen Congyang, 2012/04/18
- [Qemu-devel] [PATCH 06/12 v12] Add API to get memory mapping without do paging, Wen Congyang, 2012/04/18
- [Qemu-devel] [PATCH 07/12 v12] target-i386: Add API to write elf notes to core file, Wen Congyang, 2012/04/18
- [Qemu-devel] [PATCH 08/12 v12] target-i386: Add API to write cpu status to core file, Wen Congyang, 2012/04/18
- [Qemu-devel] [PATCH 09/12 v12] target-i386: add API to get dump info, Wen Congyang, 2012/04/18
- [Qemu-devel] [PATCH 10/12 v12] make gdb_id() generally avialable and rename it to cpu_index(), Wen Congyang, 2012/04/18
- [Qemu-devel] [PATCH 11/12 v12] QError: Introduce new error for the dump-guest-memory command, Wen Congyang, 2012/04/18
- [Qemu-devel] [PATCH 12/12 v12] introduce a new monitor command 'dump-guest-memory' to dump guest's memory, Wen Congyang, 2012/04/18
- Re: [Qemu-devel] [PATCH 12/12 v12] introduce a new monitor command 'dump-guest-memory' to dump guest's memory, Wen Congyang, 2012/04/18
- Re: [Qemu-devel] [PATCH 12/12 v12] introduce a new monitor command 'dump-guest-memory' to dump guest's memory, Daniel P. Berrange, 2012/04/18