Re: [Qemu-devel] [PATCH 15/18] qapi: implement support for variable argument list

[Anthony Liguori]

On 04/17/2012 03:26 PM, Paolo Bonzini wrote:
> Il 17/04/2012 21:36, Luiz Capitulino ha scritto:
> > +            switch(qobject_type(obj)) {
> > +            case QTYPE_QSTRING:
> > +                qstring_append(arglist,
> > +                               qstring_get_str(qobject_to_qstring(obj)));
> > +                break;
>
> Does this escape commas correctly?
>
> It seems much easier to use no_gen and qemu_opts_from_qdict...  Then
> cmd_netdev_add can be
>
>    void cmd_foo(QemuOpts *arglist, Error **errp);
>
> and later on we could even replace the QemuOpts with a visitor for full
> QAPI-ness...

Yeah, I think that's a reasonable suggestion.

Regards,

Anthony Liguori

> Paolo