[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 03/13] target-sh4: Start QOM'ifying CPU init
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v3 03/13] target-sh4: Start QOM'ifying CPU init |
Date: |
Mon, 16 Apr 2012 15:39:02 +0100 |
On 14 April 2012 23:12, Andreas Färber <address@hidden> wrote:
> +static void superh_cpu_initfn(Object *obj)
> +{
> + SuperHCPU *cpu = SUPERH_CPU(obj);
> + CPUSH4State *env = &cpu->env;
> +
> + cpu_exec_init(env);
> +
> + env->movcal_backup_tail = &(env->movcal_backup);
> +
> + cpu_reset(CPU(cpu));
> +}
> +
[rats, made this comment on the v2 patch by mistake, here it
is again as a reply to the correct email...]
Do the other qom conversions do a cpu reset in the instance
init function? I don't think the ARM one does (and it would
probably be bad if it did since reset for some ARM cores
requires loading values from guest memory so it can't happen
before the whole of the model has been set up.)
We should aim for consistency across targets here I think.
-- PMM
- [Qemu-devel] [PATCH v3 00/13] QOM'ify SuperH CPU, Andreas Färber, 2012/04/14
- [Qemu-devel] [PATCH v3 04/13] target-sh4: Do not reset CPU feature flags on reset, Andreas Färber, 2012/04/14
- [Qemu-devel] [PATCH v3 03/13] target-sh4: Start QOM'ifying CPU init, Andreas Färber, 2012/04/14
- Re: [Qemu-devel] [PATCH v3 03/13] target-sh4: Start QOM'ifying CPU init,
Peter Maydell <=
- [Qemu-devel] [PATCH v3 01/13] target-sh4: QOM'ify CPU, Andreas Färber, 2012/04/14
- [Qemu-devel] [PATCH v3 02/13] target-sh4: QOM'ify CPU reset, Andreas Färber, 2012/04/14
- [Qemu-devel] [PATCH v3 05/13] hw/sh7750: Use SuperHCPU, Andreas Färber, 2012/04/14
- [Qemu-devel] [PATCH v3 08/13] target-sh4: Make find_*tlb_entry() take SuperHCPU, Andreas Färber, 2012/04/14
- [Qemu-devel] [PATCH v3 06/13] target-sh4: Make cpu_sh4_invalidate_tlb() take SuperHCPU, Andreas Färber, 2012/04/14
- [Qemu-devel] [PATCH v3 07/13] target-sh4: Make increment_urc() take SuperHCPU, Andreas Färber, 2012/04/14