qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 03/13] target-sh4: Start QOM'ifying CPU init


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v3 03/13] target-sh4: Start QOM'ifying CPU init
Date: Mon, 16 Apr 2012 15:39:02 +0100

On 14 April 2012 23:12, Andreas Färber <address@hidden> wrote:
> +static void superh_cpu_initfn(Object *obj)
> +{
> +    SuperHCPU *cpu = SUPERH_CPU(obj);
> +    CPUSH4State *env = &cpu->env;
> +
> +    cpu_exec_init(env);
> +
> +    env->movcal_backup_tail = &(env->movcal_backup);
> +
> +    cpu_reset(CPU(cpu));
> +}
> +

[rats, made this comment on the v2 patch by mistake, here it
is again as a reply to the correct email...]

Do the other qom conversions do a cpu reset in the instance
init function? I don't think the ARM one does (and it would
probably be bad if it did since reset for some ARM cores
requires loading values from guest memory so it can't happen
before the whole of the model has been set up.)
We should aim for consistency across targets here I think.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]