qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [patch V5 3/5] FreeSCALE i.MX31 support: Timers


From: Peter Chubb
Subject: Re: [Qemu-devel] [patch V5 3/5] FreeSCALE i.MX31 support: Timers
Date: Tue, 10 Apr 2012 16:48:28 +1000
User-agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.8 Emacs/23.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)

>>>>> "Peter" == Peter Chubb <address@hidden> writes:

Peter> I'm not sure how to make qdev properties work.  The timers need
Peter> to be able to get at the CCM-generated frequencies, which of
Peter> course are private to the CCM.

I've just split the problematic function into two:
iomx_timerg_create() and imx_timerp_create(). That gets rid of the
strcmp, and makes it more obvious what's going on.  Because there will
only ever be one CCM, there's no point in making it a property.

I'm still not sure what to do about rate-limiting timer timeouts.  I
agree with you, Peter M, that it should be handled in the QEMU timer
layer somewhere.  Having had another look at the code, I really don't
want to touch it.

Peter C

--
Dr Peter Chubb                                  peter.chubb AT nicta.com.au
http://www.ssrg.nicta.com.au          Software Systems Research Group/NICTA



reply via email to

[Prev in Thread] Current Thread [Next in Thread]