[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 6/7] block: push bdrv_change_backing_file error chec
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 6/7] block: push bdrv_change_backing_file error checking up from drivers |
Date: |
Thu, 5 Apr 2012 17:43:00 +0200 |
Signed-off-by: Paolo Bonzini <address@hidden>
---
block.c | 5 +++++
block/qcow2.c | 5 -----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/block.c b/block.c
index e806ad8..e293882 100644
--- a/block.c
+++ b/block.c
@@ -1403,6 +1403,11 @@ int bdrv_change_backing_file(BlockDriverState *bs,
{
BlockDriver *drv = bs->drv;
+ /* Backing file format doesn't make sense without a backing file */
+ if (backing_fmt && !backing_file) {
+ return -EINVAL;
+ }
+
if (drv->bdrv_change_backing_file != NULL) {
return drv->bdrv_change_backing_file(bs, backing_file, backing_fmt);
} else {
diff --git a/block/qcow2.c b/block/qcow2.c
index 70d3141..342d8ff 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -843,11 +843,6 @@ fail:
static int qcow2_change_backing_file(BlockDriverState *bs,
const char *backing_file, const char *backing_fmt)
{
- /* Backing file format doesn't make sense without a backing file */
- if (backing_fmt && !backing_file) {
- return -EINVAL;
- }
-
pstrcpy(bs->backing_file, sizeof(bs->backing_file), backing_file ?: "");
pstrcpy(bs->backing_format, sizeof(bs->backing_format), backing_fmt ?: "");
--
1.7.9.3
- Re: [Qemu-devel] [PATCH 1/7] block: add mode argument to blockdev-snapshot-sync, (continued)
- [Qemu-devel] [PATCH 2/7] block: fail live snapshot if disk has no medium, Paolo Bonzini, 2012/04/05
- [Qemu-devel] [PATCH 3/7] block: fix snapshot with QED format, Paolo Bonzini, 2012/04/05
- [Qemu-devel] [PATCH 4/7] block: close unused image files at the end of streaming, Paolo Bonzini, 2012/04/05
- [Qemu-devel] [PATCH 5/7] block: pass new base image format to bdrv_change_backing_file, Paolo Bonzini, 2012/04/05
- [Qemu-devel] [PATCH 7/7] block: update in-memory backing file and format, Paolo Bonzini, 2012/04/05
- [Qemu-devel] [PATCH 6/7] block: push bdrv_change_backing_file error checking up from drivers,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 0/7] Miscellaneous fixes for block and snapshots, Paolo Bonzini, 2012/04/12