[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API |
Date: |
Wed, 04 Apr 2012 18:55:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-04-04 18:39, Paolo Bonzini wrote:
> Il 04/04/2012 18:05, Jan Kiszka ha scritto:
>>>> Perhaps you can take the relevant patches out of the thread-blocks
>>>> branch at git://github.com/pbonzini/qemu.git? The iothread eventfd
>>>> could also use an EventNotifier.
>> Yep, this screams for something like QemuEvent which pleases all users
>> of current qemu_eventfd and EventNotifier - and fit into the existing
>> threading/synchronization abstraction layout.
>
> Kind of, on Unix you cannot poll synchronization primitives so
> EventNotifier has to remain separate from qemu-thread.
QemuEvent will be pollable as you can ask it for its read fd:
void qemu_event_init(QemuEvent *event, bool signaled);
void qemu_event_destroy(QemuEvent *event);
int qemu_event_get_write_fd(QemuEvent *event);
int qemu_event_get_read_fd(QemuEvent *event);
void qemu_event_signal(QemuEvent *event);
bool qemu_event_check(QemuEvent *event);
I'm not yet convinced a qemu_event_set_handler buys us a lot, so I
prefer the get_read_fd interface for now.
This is just a matter of code organization, and I prefer to consolidate
this under the hood of qemu-thread.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
- [Qemu-devel] [PATCH 5/5] Switch compatfd to QEMU thread, (continued)
- [Qemu-devel] [PATCH 5/5] Switch compatfd to QEMU thread, Jan Kiszka, 2012/04/04
- [Qemu-devel] [PATCH 2/5] Switch POSIX compat AIO to QEMU abstractions, Jan Kiszka, 2012/04/04
- [Qemu-devel] [PATCH 4/5] Reorder POSIX compat AIO code, Jan Kiszka, 2012/04/04
- Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API, Paolo Bonzini, 2012/04/04
- Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API, Jan Kiszka, 2012/04/04
- Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API, Jan Kiszka, 2012/04/04
- Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API, Paolo Bonzini, 2012/04/04
- Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API,
Jan Kiszka <=
- Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API, Jan Kiszka, 2012/04/04
- Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API, Paolo Bonzini, 2012/04/05
- Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API, Jan Kiszka, 2012/04/05
- Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API, Paolo Bonzini, 2012/04/05
- Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API, Jan Kiszka, 2012/04/05
- Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API, Paolo Bonzini, 2012/04/05
- Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API, Jan Kiszka, 2012/04/05
- Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API, Paolo Bonzini, 2012/04/05
- Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API, Jan Kiszka, 2012/04/06
- Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API, Paolo Bonzini, 2012/04/05