Re: [Qemu-devel] [RFC PATCH v1 2/4] m25p80: initial verion

[Andreas Färber]

Am 30.03.2012 08:37, schrieb Peter A. G. Crosthwaite:
> Added device model for m25p80 SPI flash
> 
> Signed-off-by: Peter A. G. Crosthwaite <address@hidden>
> ---
>  Makefile.target |    1 +
>  hw/m25p80.c     |  495 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 496 insertions(+), 0 deletions(-)
>  create mode 100644 hw/m25p80.c
> 
> diff --git a/Makefile.target b/Makefile.target
> index 8fd3718..fcccf1b 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -321,6 +321,7 @@ obj-microblaze-y = petalogix_s3adsp1800_mmu.o
>  obj-microblaze-y += petalogix_ml605_mmu.o
>  obj-microblaze-y += microblaze_boot.o
>  obj-microblaze-y += spi.o
> +obj-microblaze-y += m25p80.o
>  
>  obj-microblaze-y += microblaze_pic_cpu.o
>  obj-microblaze-y += xilinx_intc.o
> diff --git a/hw/m25p80.c b/hw/m25p80.c
> new file mode 100644
> index 0000000..2b67375
> --- /dev/null
> +++ b/hw/m25p80.c
> @@ -0,0 +1,495 @@
> +/*
> + * ST M25P80 emulator.
[snip]

A device by ST does not sound microblaze-specific and in that case,
similar to the recent Atmel maxtouch device, should go into
hw-obj-$(CONFIG_M25P80) instead so that it's compiled only once for
microblaze-softmmu and microblazeel-softmmu.

Same for spi.o since it implements a generic bus AFAIU.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg