Re: [Qemu-devel] [PATCHv3] piix: fix up/down races

[Michael S. Tsirkin]

On Tue, Apr 03, 2012 at 03:56:18PM +0300, Michael S. Tsirkin wrote:
> > > +    /*
> > > +     * Clear DOWN register - this is good for a case where guest can't
> > > +     * write to CLR_DOWN because of VM reset, and for compatibility with
> > > +     * old guests which do not have CLR_DOWN.
> > > +     */
> > > +    s->pci0_status.down &= ~(1U << slot);
> > 
> > Should we clear "up" here too?
> 
> On eject clearing "up" is probably OK. However I'm not sure
> what purpose would it serve, and it seems the less hacks we do the
> better.

I added a comment to clarify this.