Re: [Qemu-devel] [PATCH 07/25] qdev: use object_property_print in info qtree

[Paolo Bonzini]

Il 03/04/2012 14:28, Jan Kiszka ha scritto:
>> >          if (object_property_get_type(OBJECT(dev), legacy_name, NULL)) {
>> >              value = object_property_get_str(OBJECT(dev), legacy_name, 
>> > &err);
> This is not a criticism on this patch, but I'd like to underline that
> the line above only works because legacy props also define print
                                                 ^^^^

You mean always, I guess.

> But this statement above is still inconsistent. We should either
> assert(print && parse) or handle their non-existence properly.

Yes, asserting that print/parse are always present in pairs (if at all)
would be good.

Paolo