[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] qdev: give all devices a canonical QOM path
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] qdev: give all devices a canonical QOM path |
Date: |
Mon, 02 Apr 2012 16:21:41 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120310 Thunderbird/11.0 |
On 03/27/2012 11:38 AM, Paolo Bonzini wrote:
A strong limitation of QOM right now is that unconverted ports
(e.g. all...) do not give a canonical path to devices that are
part of the board. This in turn makes it impossible to replace
PROP_PTR with a QOM link for example.
This series fixes this by putting all such devices under a
/unattached container.
The problem is when to do this. qdev_init is a good place, but it
requires the composition tree to be in order by the time we call it.
This is not the case so far, but it can be changed easily (patch 2) at
the cost of removing most of the few composition examples that are in the
tree. This change is also necessary so that a single set of the topmost
realize property can propagate all the way down the composition tree,
as agreed on the mailing list.
At the end of the series, all devices are moved to /machine
in order to avoid cluttering too much the QOM root.
Applied all (including v2 of 4/4). Thanks.
Regards,
Anthony Liguori
Paolo Bonzini (4):
qom: add container_get
qdev: add children before qdev_init
qdev: give all devices a canonical path
qdev: put all devices under /machine
hw/pc_piix.c | 18 +-----------------
hw/piix_pci.c | 3 +--
hw/ppc_prep.c | 2 +-
hw/qdev-monitor.c | 16 ++++++----------
hw/qdev.c | 16 +++++++++++++---
include/qemu/object.h | 24 ++++++++++++++++++++++++
qom/container.c | 23 +++++++++++++++++++++++
qom/object.c | 33 +++++++++++++++++----------------
8 files changed, 86 insertions(+), 49 deletions(-)
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 0/4] qdev: give all devices a canonical QOM path,
Anthony Liguori <=