[Qemu-devel] More build breakage: signrom.sh vs kvmvapic.bin

[Brad Smith]

Here is another source of build breakage that popped up over a month ago.

The patch below fixes the build but I'm wondering why the file in question
is being built on anything but Linux. It seems to be used for KVM support
and thus has no relevance on any other OS.


  AS    optionrom/kvmvapic.o
  Building optionrom/kvmvapic.img
  Building optionrom/kvmvapic.raw
  Signing optionrom/kvmvapic.bin
/buildbot-qemu/default_openbsd_current/build/scripts/signrom.sh[31]:           
018                                                             * 512 - 1 : bad 
number `018'
gmake[1]: *** [kvmvapic.bin] Error 1


diff --git a/scripts/signrom.sh b/scripts/signrom.sh
index 9dc5c63..2d421e9 100755
--- a/scripts/signrom.sh
+++ b/scripts/signrom.sh
@@ -27,8 +27,8 @@ sum=0
 
 # find out the file size
 x=`dd if="$1" bs=1 count=1 skip=2 2>/dev/null | od -t u1 -A n`
-#size=`expr $x \* 512 - 1`
-size=$(( $x * 512 - 1 ))
+size=`expr $x \* 512 - 1`
+#size=$(( $x * 512 - 1 ))
 
 # now get the checksum
 nums=`od -A n -t u1 -v -N $size "$1"`

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.