qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH v3 1/8] tracetool: Rewrite infrastructure as


From: Lluís Vilanova
Subject: Re: [Qemu-devel] [RFC PATCH v3 1/8] tracetool: Rewrite infrastructure as python modules
Date: Fri, 30 Mar 2012 18:55:16 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux)

Stefan Hajnoczi writes:
>> +    kwargs = {}
>> +
>> +    try:
>> +        tracetool.generate(sys.stdin, arg_format, arg_backend, **kwargs)

> If forgot to ask what kwargs is doing here?   Can we default to {}?
> Otherwise let's drop it for now since there are no options defined yet.

It's used later in the patch adding dtrace support. I just thought it would be
better to maintain the interface of 'tracetool.generate' instead of adding new
parameters later when necessary.


Lluis

-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth



reply via email to

[Prev in Thread] Current Thread [Next in Thread]