[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v3 1/8] tracetool: Rewrite infrastructure as
From: |
Lluís Vilanova |
Subject: |
Re: [Qemu-devel] [RFC PATCH v3 1/8] tracetool: Rewrite infrastructure as python modules |
Date: |
Fri, 30 Mar 2012 18:55:16 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) |
Stefan Hajnoczi writes:
>> + kwargs = {}
>> +
>> + try:
>> + tracetool.generate(sys.stdin, arg_format, arg_backend, **kwargs)
> If forgot to ask what kwargs is doing here? Can we default to {}?
> Otherwise let's drop it for now since there are no options defined yet.
It's used later in the patch adding dtrace support. I just thought it would be
better to maintain the interface of 'tracetool.generate' instead of adding new
parameters later when necessary.
Lluis
--
"And it's much the same thing with knowledge, for whenever you learn
something new, the whole world becomes that much richer."
-- The Princess of Pure Reason, as told by Norton Juster in The Phantom
Tollbooth
- [Qemu-devel] [RFC PATCH v3 0/8] Rewrite tracetool using python modules, Lluís Vilanova, 2012/03/27
- [Qemu-devel] [RFC PATCH v3 1/8] tracetool: Rewrite infrastructure as python modules, Lluís Vilanova, 2012/03/27
- [Qemu-devel] [RFC PATCH v3 2/8] tracetool: Add module for the 'c' format, Lluís Vilanova, 2012/03/27
- [Qemu-devel] [RFC PATCH v3 3/8] tracetool: Add module for the 'h' format, Lluís Vilanova, 2012/03/27
- [Qemu-devel] [RFC PATCH v3 4/8] tracetool: Add support for the 'stderr' backend, Lluís Vilanova, 2012/03/27
- [Qemu-devel] [RFC PATCH v3 5/8] tracetool: Add support for the 'simple' backend, Lluís Vilanova, 2012/03/27
- [Qemu-devel] [RFC PATCH v3 6/8] tracetool: Add support for the 'ust' backend, Lluís Vilanova, 2012/03/27
- [Qemu-devel] [RFC PATCH v3 7/8] tracetool: Add support for the 'dtrace' backend, Lluís Vilanova, 2012/03/27
- [Qemu-devel] [RFC PATCH v3 8/8] tracetool: Add MAINTAINERS info, Lluís Vilanova, 2012/03/27
- Re: [Qemu-devel] [RFC PATCH v3 0/8] Rewrite tracetool using python modules, Stefan Hajnoczi, 2012/03/29