[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/13] qapi: support for keyworded variable-leng
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 12/13] qapi: support for keyworded variable-length argument list |
Date: |
Fri, 30 Mar 2012 09:49:20 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 |
Il 29/03/2012 22:01, Anthony Liguori ha scritto:
>> Then, we open-code the marshaller to process the QDict, rather than
>> embedding
>> it in the script or passing it through to qmp_device_add().
>
> You could also just do gen=False...
>
> But I don't think open coding the marshaller is the right thing here.
> You have to convert to strings and reparse anyway.
device_add expects strings, you don't have to convert no? There is a
single parse point.
(Instead, a qom_add would accept the right types, but then it would also
use a more QAPI-friendly syntax with lists insteads of varargs).
Regarding device_add ? and device_add foo,? I would implement it as
separate QMP commands hooking into QOM, such as qom_list_types (taking
the superclass as an optional argument) and qom_properties. But the
latter first needs static properties to move up from devices to objects.
I'll take a look at that.
Paolo
- [Qemu-devel] [PATCH 03/13] qemu-option: parse_option_bool(): use error_set(), (continued)
- [Qemu-devel] [PATCH 03/13] qemu-option: parse_option_bool(): use error_set(), Luiz Capitulino, 2012/03/29
- [Qemu-devel] [PATCH 08/13] qemu-option: introduce qemu_opt_set_err(), Luiz Capitulino, 2012/03/29
- [Qemu-devel] [PATCH 12/13] qapi: support for keyworded variable-length argument list, Luiz Capitulino, 2012/03/29
- Re: [Qemu-devel] [PATCH 12/13] qapi: support for keyworded variable-length argument list, Anthony Liguori, 2012/03/29
- Re: [Qemu-devel] [PATCH 12/13] qapi: support for keyworded variable-length argument list, Michael Roth, 2012/03/29
- Re: [Qemu-devel] [PATCH 12/13] qapi: support for keyworded variable-length argument list, Anthony Liguori, 2012/03/29
- Re: [Qemu-devel] [PATCH 12/13] qapi: support for keyworded variable-length argument list, Michael Roth, 2012/03/29
- Re: [Qemu-devel] [PATCH 12/13] qapi: support for keyworded variable-length argument list, Michael Roth, 2012/03/29
- Re: [Qemu-devel] [PATCH 12/13] qapi: support for keyworded variable-length argument list,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 12/13] qapi: support for keyworded variable-length argument list, Luiz Capitulino, 2012/03/30
- Re: [Qemu-devel] [PATCH 12/13] qapi: support for keyworded variable-length argument list, Paolo Bonzini, 2012/03/29
[Qemu-devel] [PATCH 13/13] qapi: convert device_add, Luiz Capitulino, 2012/03/29
[Qemu-devel] [PATCH 05/13] qemu-option: qemu_opt_parse(): use error_set(), Luiz Capitulino, 2012/03/29
[Qemu-devel] [PATCH 10/13] qemu-config: find_list(): use error_set(), Luiz Capitulino, 2012/03/29
[Qemu-devel] [PATCH 11/13] qemu-config: introduce qemu_find_opts_err(), Luiz Capitulino, 2012/03/29