[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V3 03/12] Add MIPS DSP Branch instruction Suppor
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH V3 03/12] Add MIPS DSP Branch instruction Support |
Date: |
Tue, 27 Mar 2012 08:46:34 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120316 Thunderbird/11.0 |
On 03/27/12 02:24, Jia Liu wrote:
> Add MIPS DSP Branch instruction Support.
>
> Signed-off-by: Jia Liu <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
> + case OPC_BPOSGE32:
> + tcg_gen_setcondi_tl(TCG_COND_GT, bcond, t0, 31);
Nit: It might be better to use TCG_COND_GE ... 32, since that's
both the name of the insn and its official documentation. Of
course that makes no difference to the correctness.
r~
- [Qemu-devel] [PATCH V3 00/12] Qemu MIPS ASE DSP Sup port, Jia Liu, 2012/03/27
- [Qemu-devel] [PATCH V3 01/12] add MIPS DSP internal functions, Jia Liu, 2012/03/27
- [Qemu-devel] [PATCH V3 02/12] Use correct acc value to index cpu_HI/cpu_LO rather than using a fix number, Jia Liu, 2012/03/27
- [Qemu-devel] [PATCH V3 03/12] Add MIPS DSP Branch instruction Support, Jia Liu, 2012/03/27
- Re: [Qemu-devel] [PATCH V3 03/12] Add MIPS DSP Branch instruction Support,
Richard Henderson <=
- [Qemu-devel] [PATCH V3 04/12] Add MIPS DSP Load instructions Support, Jia Liu, 2012/03/27
- [Qemu-devel] [PATCH V3 05/12] Add helper functions for MIPS DSP Arithmetic instructions, Jia Liu, 2012/03/27
- [Qemu-devel] [PATCH V3 06/12] Add helper functions for MIPS DSP GPR-Based Shift instructions, Jia Liu, 2012/03/27