Re: [Qemu-devel] [RFC PATCH 0/8] Rewrite tracetool using python modules

[Stefan Hajnoczi]

On Thu, Mar 22, 2012 at 9:42 PM, Lluís Vilanova <address@hidden> wrote:
> A full rewrite of the tracetool script using per-format and per-backend 
> modules,
> so that it's easier to read and extend it in the future.
>
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
> NOTE: This series applies in current master, ignoring the "Rewrite tracetool
>      using python" series.
>
> Lluís Vilanova (8):
>      tracetool: Rewrite infrastructure as python modules
>      tracetool: Add module for the 'c' format
>      tracetool: Add module for the 'h' format
>      tracetool: Add support for the 'stderr' backend
>      tracetool: Add support for the 'simple' backend
>      tracetool: Add support for the 'ust' backend
>      tracetool: Add support for the 'dtrace' backend
>      tracetool: Add MAINTAINERS info
>
>
>  MAINTAINERS                           |    2
>  Makefile.objs                         |    6
>  Makefile.target                       |   13 -
>  configure                             |    4
>  scripts/tracetool                     |  648 
> ---------------------------------
>  scripts/tracetool.py                  |  141 +++++++
>  scripts/tracetool/__init__.py         |  210 +++++++++++
>  scripts/tracetool/backend/__init__.py |  112 ++++++
>  scripts/tracetool/backend/dtrace.py   |  104 +++++
>  scripts/tracetool/backend/simple.py   |   60 +++
>  scripts/tracetool/backend/stderr.py   |   61 +++
>  scripts/tracetool/backend/ust.py      |  102 +++++
>  scripts/tracetool/format/__init__.py  |   89 +++++
>  scripts/tracetool/format/c.py         |   20 +
>  scripts/tracetool/format/d.py         |   20 +
>  scripts/tracetool/format/h.py         |   45 ++
>  scripts/tracetool/format/stap.py      |   20 +
>  17 files changed, 998 insertions(+), 659 deletions(-)
>  delete mode 100755 scripts/tracetool
>  create mode 100755 scripts/tracetool.py
>  create mode 100644 scripts/tracetool/__init__.py
>  create mode 100644 scripts/tracetool/backend/__init__.py
>  create mode 100644 scripts/tracetool/backend/dtrace.py
>  create mode 100644 scripts/tracetool/backend/simple.py
>  create mode 100644 scripts/tracetool/backend/stderr.py
>  create mode 100644 scripts/tracetool/backend/ust.py
>  create mode 100644 scripts/tracetool/format/__init__.py
>  create mode 100644 scripts/tracetool/format/c.py
>  create mode 100644 scripts/tracetool/format/d.py
>  create mode 100644 scripts/tracetool/format/h.py
>  create mode 100644 scripts/tracetool/format/stap.py

I tried to build this after make distclean with the nop backend:

  GEN   trace.h
Traceback (most recent call last):
  File "/home/stefanha/qemu/scripts/tracetool.py", line 141, in <module>
    main(sys.argv)
  File "/home/stefanha/qemu/scripts/tracetool.py", line 136, in main
    tracetool.generate(sys.stdin, arg_format, arg_backend, **kwargs)
  File "/home/stefanha/qemu/scripts/tracetool/__init__.py", line 177,
in generate
    if not tracetool.format.exists(mformat):
UnboundLocalError: local variable 'tracetool' referenced before assignment

Do you also get this error?

Stefan