qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Makefile: Set default locale C


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] Makefile: Set default locale C
Date: Sat, 24 Mar 2012 12:44:03 +0000

On 23 March 2012 20:05, Stefan Weil <address@hidden> wrote:
> +# Set default locale for commands like tr and others.
> +LANG=C
> +LC_ALL=C
> +LC_CTYPE=C

You don't export these, which leads to an obscure corner case:
if the user has no LANG variable set in their environment when
they run make then we will set LANG=C in the top level makefile
but it will not be set in a sub-makefile. Since the default
locale is the same as the C locale this doesn't make any
practical difference, but it's a little odd.

(Make automatically exports variables to submakes if they had
some value in its environment when it was started, but not if
they were only set in the makefile.)

Also, do we need to set these in configure too?

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]