[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 0/4] MIPS ASE DSP Support for Qemu
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH V2 0/4] MIPS ASE DSP Support for Qemu |
Date: |
Fri, 23 Mar 2012 09:01:36 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 |
> +DEF_HELPER_1(absqsph, i32, i32)
Many of these helpers merely compute a function. They do not trap,
they do not modify global state. They should be using the
DEF_HELPER_FLAGS_N macro to define them, so that the TCG compiler
can optimize around the functions better.
> target-mips/op_helper.c | 3936
> +++++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 3936 insertions(+), 0 deletions(-)
Nearly 4000 lines to me says: put these in their own file.
It would be my preference if this were done in a way that
exposes any implicit uses of the ENV variable. But even
failing that, the makefile can be adjusted to apply HELPER_CFLAGS
to other helper files.
r~
- [Qemu-devel] [PATCH V2 3/4] add MIPS DSP translation, (continued)
- [Qemu-devel] [PATCH V2 3/4] add MIPS DSP translation, Jia Liu, 2012/03/22
- [Qemu-devel] [PATCH V2 2/4] add MIPS DSP helpers implement, Jia Liu, 2012/03/22
- [Qemu-devel] [PATCH V2 4/4] add MIPS DSP testcase, Jia Liu, 2012/03/22
- Re: [Qemu-devel] [PATCH V2 0/4] MIPS ASE DSP Support for Qemu, Peter Maydell, 2012/03/22
- Re: [Qemu-devel] [PATCH V2 0/4] MIPS ASE DSP Support for Qemu, Peter Maydell, 2012/03/22
- Re: [Qemu-devel] [PATCH V2 0/4] MIPS ASE DSP Support for Qemu,
Richard Henderson <=