[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [Bug 961757] [NEW] wrong error for blockdev-snapshot-sync
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [Bug 961757] [NEW] wrong error for blockdev-snapshot-sync |
Date: |
Wed, 21 Mar 2012 23:11:46 -0000 |
Public bug reported:
>From Laszlo Ersek:
>> + proto_drv = bdrv_find_protocol(snapshot_file);
>> if (!proto_drv) {
>> - qerror_report(QERR_INVALID_BLOCK_FORMAT, format);
>> - ret = -1;
>> - goto out;
>> + error_set(errp, QERR_INVALID_BLOCK_FORMAT, format);
>> + return;
>> }
>
> I don't understand the logic here (based on the error message). We
> specified "format" for the case when a completely new snapshot file has
> to be created. If the file exists already, then bdrv_find_protocol()
> tries to find the driver for it. If that fails, then we must report an
> error indeed, but instead of referring to "format", we'd have to report
> the "scheme" from the beginning of "snapshot_file".
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/961757
Title:
wrong error for blockdev-snapshot-sync
Status in QEMU:
New
Bug description:
From Laszlo Ersek:
>> + proto_drv = bdrv_find_protocol(snapshot_file);
>> if (!proto_drv) {
>> - qerror_report(QERR_INVALID_BLOCK_FORMAT, format);
>> - ret = -1;
>> - goto out;
>> + error_set(errp, QERR_INVALID_BLOCK_FORMAT, format);
>> + return;
>> }
>
> I don't understand the logic here (based on the error message). We
> specified "format" for the case when a completely new snapshot file has
> to be created. If the file exists already, then bdrv_find_protocol()
> tries to find the driver for it. If that fails, then we must report an
> error indeed, but instead of referring to "format", we'd have to report
> the "scheme" from the beginning of "snapshot_file".
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/961757/+subscriptions
[Prev in Thread] |
Current Thread |
[Next in Thread] |