Re: [Qemu-devel] [PATCH 3/3] configure: add --confsuffix option

[Eduardo Habkost]

On Wed, Mar 21, 2012 at 01:39:39PM +0100, Paolo Bonzini wrote:
> Il 20/03/2012 21:15, Eduardo Habkost ha scritto:
> > This way we can choose a configuration file path different from
> > ${sysconfdir}/PACKAGE.
> > 
> > This also changes the configure output to show the full configuration
> > dir path (including $confsuffix), instead of just $sysconfdir.
> 
> Can you please apply this to datadir too?  (i.e. set the datadir default
> to just $prefix/share, and later add $confsuffix).

I will do it, and send v3 of the series.

I guess we don't want to change the meaning of
'./configure --datadir=PATH' (that currently expects the full path), to
keep compatibility, right?


To make sure the expected semantics are clear:

This is straightforward:

./configure
  qemu data dir: /usr/share/qemu
  qemu conf dir: /etc/qemu


For this one, we would have compatibility issues to take care of:

./configure --datadir=FOO --sysconfdir=SYS
  qemu data dir: FOO
    (it would be better if it was FOO/qemu, but needed for compatibility)
  qemu conf dir: SYS/qemu


On the following cases, I don't know what would be the best behavior:

./configure --datadir=FOO --confsuffix=/BAR
  qemu data dir: FOO/BAR
   (maybe it should be just FOO, to keep the rules easier to understand?)
  qemu conf dir: /etc/BAR

./configure --datadir=FOO --confsuffix=/BAR --sysconfdir=SYS
  qemu data dir: FOO/BAR
   (maybe it should be just FOO, to keep the rules easier to understand?)
  qemu conf dir: SYS/BAR

-- 
Eduardo