[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/7] qxl: init_pipe_signaling: exit on failure
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 3/7] qxl: init_pipe_signaling: exit on failure |
Date: |
Mon, 19 Mar 2012 14:30:34 +0100 |
From: Alon Levy <address@hidden>
If pipe creation fails, exit, don't log and continue. Fix indentation at
the same time.
Signed-off-by: Alon Levy <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/qxl.c | 21 +++++++++++----------
1 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index e17b0e3..26ca893 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1452,16 +1452,17 @@ static void qxl_send_events(PCIQXLDevice *d, uint32_t
events)
static void init_pipe_signaling(PCIQXLDevice *d)
{
- if (pipe(d->pipe) < 0) {
- dprint(d, 1, "%s: pipe creation failed\n", __FUNCTION__);
- return;
- }
- fcntl(d->pipe[0], F_SETFL, O_NONBLOCK);
- fcntl(d->pipe[1], F_SETFL, O_NONBLOCK);
- fcntl(d->pipe[0], F_SETOWN, getpid());
-
- qemu_thread_get_self(&d->main);
- qemu_set_fd_handler(d->pipe[0], pipe_read, NULL, d);
+ if (pipe(d->pipe) < 0) {
+ fprintf(stderr, "%s:%s: qxl pipe creation failed\n",
+ __FILE__, __func__);
+ exit(1);
+ }
+ fcntl(d->pipe[0], F_SETFL, O_NONBLOCK);
+ fcntl(d->pipe[1], F_SETFL, O_NONBLOCK);
+ fcntl(d->pipe[0], F_SETOWN, getpid());
+
+ qemu_thread_get_self(&d->main);
+ qemu_set_fd_handler(d->pipe[0], pipe_read, NULL, d);
}
/* graphics console */
--
1.7.1
- [Qemu-devel] [PULL 0/7] spice patch queue, Gerd Hoffmann, 2012/03/19
- [Qemu-devel] [PATCH 4/7] qxl: switch qxl.c to trace-events, Gerd Hoffmann, 2012/03/19
- [Qemu-devel] [PATCH 2/7] monitor: fix client_migrate_info error handling, Gerd Hoffmann, 2012/03/19
- [Qemu-devel] [PATCH 6/7] hw/qxl.c: Fix compilation failures on 32 bit hosts, Gerd Hoffmann, 2012/03/19
- [Qemu-devel] [PATCH 1/7] spice: set spice uuid and name, Gerd Hoffmann, 2012/03/19
- [Qemu-devel] [PATCH 5/7] qxl/qxl_render.c: add trace events, Gerd Hoffmann, 2012/03/19
- [Qemu-devel] [PATCH 3/7] qxl: init_pipe_signaling: exit on failure,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 7/7] spice: fix broken initialization, Gerd Hoffmann, 2012/03/19
- Re: [Qemu-devel] [PULL 0/7] spice patch queue, Anthony Liguori, 2012/03/19