Re: [Qemu-devel] [PATCH 5/5] memory: get rid of cpu_register_io_memory()

[Avi Kivity]

On 03/19/2012 12:37 PM, TeLeMan wrote:
> On Mon, Mar 19, 2012 at 17:16, Avi Kivity <address@hidden> wrote:
> > On 03/19/2012 06:52 AM, TeLeMan wrote:
> >> >  static bool memory_region_wrong_endianness(MemoryRegion *mr)
> >> > @@ -942,7 +940,7 @@ void memory_region_init_io(MemoryRegion *mr,
> >> >     mr->opaque = opaque;
> >> >     mr->terminates = true;
> >> >     mr->destructor = memory_region_destructor_iomem;
> >> > -    mr->ram_addr = cpu_register_io_memory(mr);
> >> > +    mr->ram_addr = ~(ram_addr_t)0;
> >> Why not 0 but -1?
> >>
> >
> > To catch bugs.  In fact it triggered bugs (not the ones I wanted though).
> There may be BSOD on the guest windows xp after applying this patch.
>

May? Where?

-- 
error compiling committee.c: too many arguments to function