Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

[Blue Swirl]

On Sun, Mar 18, 2012 at 12:13, Avi Kivity <address@hidden> wrote:
> On 03/18/2012 02:10 PM, Blue Swirl wrote:
>> On Sun, Mar 18, 2012 at 12:08, Avi Kivity <address@hidden> wrote:
>> > On 03/18/2012 12:51 PM, Blue Swirl wrote:
>> >> >
>> >> > IMO, my patch is better.  tlb_set_page() should not deal with offsets
>> >> > within a page.
>> >>
>> >> It looks like all targets except Sparc32/64 mask the addresses before
>> >> passing to tlb_set_page(), so I agree.
>> >
>> > Ok.  Commit my patch then?
>>
>> I sent a different patch which masks incoming address earlier and
>> removes unnecessary masking in other places.
>
> My patch missed the "boot mode" thing.  Does your patch fix it?

Yes. I also fixed both Sparc32 (which didn't have problems) and Sparc64.

>
> --
> error compiling committee.c: too many arguments to function
>