[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 2/6] Introduce "save_devices"
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH v6 2/6] Introduce "save_devices" |
Date: |
Fri, 16 Mar 2012 16:10:27 +0000 |
User-agent: |
Alpine 2.00 (DEB 1167 2008-08-23) |
On Fri, 16 Mar 2012, Eric Blake wrote:
> On 03/15/2012 02:34 PM, Luiz Capitulino wrote:
> > On Thu, 15 Mar 2012 15:16:15 -0500
> > Anthony Liguori <address@hidden> wrote:
> >
> >> On 03/15/2012 01:19 PM, Stefano Stabellini wrote:
> >>> - add an "is_ram" flag to SaveStateEntry;
> >>>
> >>> - register_savevm_live sets is_ram for live_savevm devices;
> >>>
> >>> - introduce a "save_devices" QAPI command that can be used to save
> >>> the state of all devices, but not the RAM or the block devices of the
> >>> VM.
> >>>
>
> >>> +SQMP
> >>> +save_devices
> >>> +-------
> >>> +
> >>> +Save the state of all devices to file. The RAM and the block devices
> >>> +of the VM are not saved by this command.
> >>> +
> >>> +Arguments:
> >>> +
> >>> +- "filename": the file to save the state of the devices to as binary
> >>> +data. See save_devices.txt for a description of the binary format.
> >>> +
> >>> +Example:
> >>> +
> >>> +-> { "execute": "save_devices", "arguments": { "filename": "/tmp/save"
> >>> } }
>
> Why are we adding yet another command without support for passing in an
> fd instead of having qemu open the file name? Libvirt really does want
> to move to an ability to pass in fds, and the more commands we add that
> open files, the harder converting them all will be.
This command is not meant to be used by libvirt directly: it is meant to
be used by libxenlight. Libvirt is just going to call
libxl_domain_suspend and behind the scenes libxl is going to take care
of everything.
- [Qemu-devel] [PATCH v6 6/6] xen: do not allocate RAM during INMIGRATE runstate, (continued)
- [Qemu-devel] [PATCH v6 6/6] xen: do not allocate RAM during INMIGRATE runstate, Stefano Stabellini, 2012/03/15
- [Qemu-devel] [PATCH v6 4/6] xen: record physmap changes to xenstore, Stefano Stabellini, 2012/03/15
- [Qemu-devel] [PATCH v6 3/6] Set runstate to INMIGRATE earlier, Stefano Stabellini, 2012/03/15
- [Qemu-devel] [PATCH v6 5/6] xen mapcache: check if memory region has moved., Stefano Stabellini, 2012/03/15
- [Qemu-devel] [PATCH v6 1/6] cirrus_vga: do not reset videoram, Stefano Stabellini, 2012/03/15
- [Qemu-devel] [PATCH v6 2/6] Introduce "save_devices", Stefano Stabellini, 2012/03/15
- Re: [Qemu-devel] [PATCH v6 2/6] Introduce "save_devices", Stefano Stabellini, 2012/03/16