qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 3/3] Minimal ARM LPAE support.


From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH v4 3/3] Minimal ARM LPAE support.
Date: Thu, 15 Mar 2012 17:42:14 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1

On 03/15/2012 05:37 PM, Peter Maydell wrote:
> On 15 March 2012 15:31, Avi Kivity <address@hidden> wrote:
> > On 03/15/2012 05:24 PM, Peter Maydell wrote:
> >> On 15 March 2012 15:20, Avi Kivity <address@hidden> wrote:
> >> > Please add code that detects the use of unimplemented features and
> >> > aborts
> >>
> >> I'm not a great fan of letting the guest cause QEMU to abort...
> >
> > Why not?  It (the guest) is going to malfunction anyway.
>
> It would be cleaner to cause the guest to take an exception
> IMHO. (This is typically what ought to happen anyway if the
> guest accesses an unimplemented cp15 register, although our
> current mess has a habit of underdecoding these things.)

At the very least, print something out so it's clear that qemu may be at
fault, not the guest.  This is what kvm does in such cases (which we
discourage, but still exist).

-- 
error compiling committee.c: too many arguments to function




reply via email to

[Prev in Thread] Current Thread [Next in Thread]