[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] kvmvapic: align start address as well as size
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH] kvmvapic: align start address as well as size |
Date: |
Thu, 15 Mar 2012 11:55:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 |
On 03/14/2012 10:33 PM, Anthony Liguori wrote:
> On 03/06/2012 09:50 AM, Avi Kivity wrote:
>> The kvmvapic code remaps a section of ROM as RAM to allow the guest to
>> maintain state there. It is careful to align the section size to a page
>> boundary, to avoid creating subpages, but neglects to do the same for
>> the start address. These leads to an assert later on when the memory
>> core tries to create a page which is half RAM and half ROM.
>>
>> Fix by aligning the start address to a page boundary.
>>
>> This can be triggered by running qemu-system-x86_64 -enable-kvm -vga
>> none.
>>
>> Signed-off-by: Avi Kivity<address@hidden>
>
> Tested-by: Anthony Liguori <address@hidden>
>
> Are you going to do a PULL request or do you want me to apply directly?
I forgot all about it, sorry.
--
error compiling committee.c: too many arguments to function