Re: [Qemu-devel] [PATCH RFC v4 14/44] target-arm: Don't overuse CPUState

[Andreas Färber]

Am 14.03.2012 15:39, schrieb Peter Maydell:
> On 10 March 2012 02:27, Andreas Färber <address@hidden> wrote:
>> Scripted conversion:
>>  sed -i "s/CPUState/CPUARMState/g" target-arm/*.[hc]
>>  sed -i "s/#define CPUARMState/#define CPUState/" target-arm/cpu.h
>>
>> Signed-off-by: Andreas Färber <address@hidden>
> 
> Some of these automated changes in iwmmxt_helper.c break the
> neatly lined up '\' macro continuation characters...
> I'm not sure I care enough to suggest that we should manually fix
> this though, especially not for the ones which are full of hard
> coded tabs.
> 
> Acked-by: Peter Maydell <address@hidden>

I didn't check every line of these automated conversions - breaking
alignment, overflowing 80 chars and not fixing
whitespace/braces/indentation on the modified lines are therefore quite
possible.

I'd rather not hack such fixes into this patch wrt rebasing but would
suggest to allow trivial cleanup patches where sensible afterwards.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg