[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC][PATCH 00/14 v9] introducing a new, dedicated memo
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC][PATCH 00/14 v9] introducing a new, dedicated memory dump mechanism |
Date: |
Wed, 14 Mar 2012 11:37:42 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 |
On 03/14/2012 11:26 AM, Luiz Capitulino wrote:
> On Wed, 14 Mar 2012 10:03:15 +0800
> Wen Congyang <address@hidden> wrote:
>
>> Changes from v8 to v9:
>> 1. remove async support(it will be reimplemented after QAPI async commands
>> support
>> is finished)
>
> I gave my review on this one (concentrating on the QMP part only), and one
> important aspect of this command is that it's a long synchronous operation.
>
> As it runs with vCPUs stopped, the only drawback is that libvirt won't be able
> to run other commands in parallel and won't be able to cancel it either. Also
> note that this command is most likely to be executed when the guest crashes.
>
> Given all this, it's fine with me to have this as a synchronous command, but
> I'd like to get an ACK from libvirt and another one from Jan and/or Anthony.
The inability to cancel is annoying (which is why I first suggested that
we add async handling and cancel back in v2 or so); but your arguments that:
1. async support will be coming in qemu 1.2, and polluting the waters
with ad-hoc async stuff in 1.1 will just make it harder
2. dump typically only gets run when a guest will no longer be running,
therefore having it be blocking is not the end of the world, as long as
the user doesn't mind the inability to cancel
are sufficient that I'm okay with a synchronous-only version for qemu
1.1. It won't be the first time libvirt has had a long-running command
it couldn't cancel (think 'savevm', for instance).
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC][PATCH 10/14 v9] make gdb_id() generally avialable, (continued)
- [Qemu-devel] [RFC][PATCH 10/14 v9] make gdb_id() generally avialable, Wen Congyang, 2012/03/13
- [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory, Wen Congyang, 2012/03/13
- [Qemu-devel] [RFC][PATCH 12/14 v9] support to cancel the current dumping, Wen Congyang, 2012/03/13
- [Qemu-devel] [RFC][PATCH 13/14 v9] support to query dumping status, Wen Congyang, 2012/03/13
- [Qemu-devel] [RFC][PATCH 14/14 v9] allow user to dump a fraction of the memory, Wen Congyang, 2012/03/13
- Re: [Qemu-devel] [RFC][PATCH 00/14 v9] introducing a new, dedicated memory dump mechanism, Luiz Capitulino, 2012/03/14