[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events |
Date: |
Tue, 13 Mar 2012 12:18:05 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Mar 13, 2012 at 10:47:54AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > What about having the frequent (read: too frequent to use stderr to dump
> > them since they clutter the screen, unless you 'stop' before each
> > monitor command) have a postfix "_freq"? This is a stopgap, but helpful
> > one, you can then do:
> > trace-event qxl* on
> > trace-event qxl*freq off
> >
> > Instead of remembering / having conveniently ready a longer list:
> > trace-event qxl* on
> > trace-event qxl_interface_get_command_enter off
> > trace-event qxl_interface_release_resource off
> > trace-event qxl_interface_get_command_ret off
> > trace-event qxl_push_free_res off
>
> Hmm, I'd suggest to just try find better names. These all are about
> ring management (well, free_res is a bit special, but still ...), so maybe:
>
> qxl_ring_{command,cursor}_check (check whenever stuff is in there)
> qxl_ring_{command,cursor}_get (take item out of the ring)
> qxl_ring_res_put (stuff item into the ring)
>
> Then you can match them likewise easy with "qxl_ring_*", but you have
> descriptive names without the IMHO ugly _freq suffix.
Sounds good.
>
> cheers,
> Gerd
>
>
- [Qemu-devel] [PATCH 1/4] qxl: switch qxl.c to trace-events, (continued)
- [Qemu-devel] [PATCH 1/4] qxl: switch qxl.c to trace-events, Alon Levy, 2012/03/11
- [Qemu-devel] [PATCH v2 0/5] fix qxl screendump using monitor_suspend, Alon Levy, 2012/03/11
- [Qemu-devel] [PATCH v2 2/5] qxl/qxl_render.c: add trace events, Alon Levy, 2012/03/11
- [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events, Alon Levy, 2012/03/11
- Re: [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events, Gerd Hoffmann, 2012/03/12
- Re: [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events, Alon Levy, 2012/03/12
- Re: [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events, Alon Levy, 2012/03/12
- Re: [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events, Gerd Hoffmann, 2012/03/13
- Re: [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events, Alon Levy, 2012/03/13
- Re: [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events, Gerd Hoffmann, 2012/03/13
- Re: [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events,
Alon Levy <=
- Re: [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events, Alon Levy, 2012/03/13
[Qemu-devel] [PATCH v2 5/5] qxl: screendump: use provided Monitor, Alon Levy, 2012/03/11
[Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump, Alon Levy, 2012/03/11
- Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump, Luiz Capitulino, 2012/03/13
- Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump, Alon Levy, 2012/03/13
- Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump, Luiz Capitulino, 2012/03/13
- Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump, Alon Levy, 2012/03/13
- Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump, Luiz Capitulino, 2012/03/13
- Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump, Gerd Hoffmann, 2012/03/14
- Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump, Alon Levy, 2012/03/14