Re: [Qemu-devel] [PATCH/RFC 0/7] Screendump to UNIX socket & in PNG format

[Jan Kiszka]

On 2012-03-12 22:22, Michael Roth wrote:
> On Mon, Mar 12, 2012 at 01:57:14PM -0500, Anthony Liguori wrote:
>> On 03/12/2012 01:56 PM, Marc-André Lureau wrote:
>>> On Mon, Mar 12, 2012 at 7:53 PM, Anthony Liguori<address@hidden>  wrote:
>>>> Why not just return the screendump through QMP?
>>>
>>> in base64, base85?
>>
>> I think Jan had patches for base64 blobs but I think it got tangled
>> up in VMState related controversy.
> 
> Few months back, was planning on using them for qemu-ga. Looks like
> they're not in yet, but FWIW qemu-ga has been using g_base64_encode() since
> initial commit. I think Jan had some reservations about g_base64_decode()'s
> error-handling, but that shouldn't be an issue in this particular case.

Yes, please don't use glib for this, just introduce a proper
error-checking implementation to QEMU. glib would require some revision
of this API to fix its deficits (still possible long-term, though).

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux