[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX
From: |
malc |
Subject: |
Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX |
Date: |
Tue, 13 Mar 2012 01:00:45 +0400 (MSK) |
User-agent: |
Alpine 2.00 (LNX 1167 2008-08-23) |
On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote:
> On Mon, Mar 12, 2012 at 9:29 PM, malc <address@hidden> wrote:
> >> So what I meant is rather G_MAXUINT32.
> >
> > Just leave it as is, it's perfectly fine.
>
> But it's not convenient to fit into a regular integer, as the number
> of steps is 2^32 + 1. Why is it preferrable this way rather than a
> MAXUINT? I must be missing something. Hardware range for example is
> usually 0...2^nbits-1
>
I really do not understand your point at all, mixeng_volume fields
are int64_t's it's irrelevant what you initialize them with, they
are still 64bit integers, and UINT_MAX as i already said is not even
correct, it's 1/(2**32-1) less than one in fixed point.
--
mailto:address@hidden
- [Qemu-devel] [PATCH 00/11] apply volume on client side (v3), Marc-André Lureau, 2012/03/12
- [Qemu-devel] [PATCH 01/11] audio: add VOICE_VOLUME ctl, Marc-André Lureau, 2012/03/12
- [Qemu-devel] [PATCH 02/11] audio: don't apply volume effect if backend has VOICE_VOLUME_CAP, Marc-André Lureau, 2012/03/12
- [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX, Marc-André Lureau, 2012/03/12
- Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX, malc, 2012/03/12
- Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX, Marc-André Lureau, 2012/03/12
- Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX, malc, 2012/03/12
- Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX, Marc-André Lureau, 2012/03/12
- Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX,
malc <=
- Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX, Marc-André Lureau, 2012/03/12
- Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX, malc, 2012/03/12
- Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX, Marc-André Lureau, 2012/03/12
- Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX, malc, 2012/03/12
- Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX, Marc-André Lureau, 2012/03/12
- Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX, malc, 2012/03/12
- Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX, Marc-André Lureau, 2012/03/12
[Qemu-devel] [PATCH 05/11] hw/ac97: the volume mask is not only 0x1f, Marc-André Lureau, 2012/03/12
[Qemu-devel] [PATCH 04/11] hw/ac97: remove USE_MIXER code, Marc-André Lureau, 2012/03/12
[Qemu-devel] [PATCH 06/11] hw/ac97: add support for volume control, Marc-André Lureau, 2012/03/12