Re: [Qemu-devel] [PATCHv2 6/7] cleanup qemu_co_sendv(), qemu_co_recvv() and friends

[Paolo Bonzini]

Il 11/03/2012 16:26, Michael Tokarev ha scritto:
> Note that - I still hope - in the end there will be no sendv or
> recv calls at all, only common sendv_recvv with is_write passed
> as an argument from upper layer.  It will be easier to remove
> that #define - just two lines of code instead of minimum 5 :)

This is what I don't really like in the second part of these patches.
You are doing changes for the sake of other changes which are not
upstream yet, for which there is no clear vision, and for which there is
no clear benefit.

While I agree that there is a lot of duplicated code in block.c and
block/*, I don't think that what we need is more parameters to the
functions.  We have places where we need to know the request flags, for
example, but the methods are already quite unwieldy and have a lot of
arguments.  So I'm not sure that this kind of unification buys anything.

On top of this, your patches unify things that are similar but not quite
identical, and you do not provide hints in the commit messages that you
did so.  For example, qemu_co_recvv has handling for receiving 0, but
qemu_co_sendv does not.

Can you please separate the changes to make the argument order uniform?
 Those should be easy to get in.

Paolo