Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors

[Luiz Capitulino]

On Fri, 09 Mar 2012 13:12:43 -0600
Anthony Liguori <address@hidden> wrote:

> On 03/09/2012 01:05 PM, Jan Kiszka wrote:
> > On 2012-03-09 19:30, Luiz Capitulino wrote:
> >> On Fri, 09 Mar 2012 19:20:56 +0100
> >> Jan Kiszka<address@hidden>  wrote:
> >>
> >>> On 2012-03-09 19:13, Luiz Capitulino wrote:
> >>>> The Monitor object is passed back and forth within the migration/savevm
> >>>> code so that it can print errors and progress to the user.
> >>>>
> >>>> However, that approach assumes a HMP monitor, being completely invalid
> >>>> in QMP.
> >>>>
> >>>> This commit drops almost every single usage of the Monitor object, all
> >>>> monitor_printf() calls have been converted into DPRINTF() ones.
> >>>
> >>> I guess for most printfs, this is OK. But do you provide an alternative
> >>> for the block migration progress output? I did not find anything on
> >>> first glance. That is not a debugging feature.
> >>
> >> Can't the info migrate command be used for that?
> >
> > This was introduced for synchronous migration, as usability improvement.
> 
> Synchronous migration doesn't exist in QMP.
> 
> It's certainly possible to make the synchronous monitor command spit out 
> status 
> as it already uses a polling loop to determine when migration completes.

As HMP now uses QMP as a real client, we'd have to make that information
available for all QMP users. Best place is probably query-migrate.

Don't you prefer to drop the whole thing instead? :-)