[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RfC PATCH 0/2] usb: reorganize source files.
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [RfC PATCH 0/2] usb: reorganize source files. |
Date: |
Fri, 09 Mar 2012 09:35:25 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) |
Gerd Hoffmann <address@hidden> writes:
> Hi,
>
>> For another, dev-foo.c is not natural English for a certain type of
>> device - foo-dev.c would be better but I'd prefer without "dev", i.e.,
>> hw/usb/{audio,ccid,...}.c. And then of course only devices should go
>> into hw/.
>
> I want a prefix because with prefixing you get the files nicely grouped
> in directory listings, without creating another directory level, which
> would IMHO be overkill for the number of files we have here.
>
> 'dev-*' is used for emulated usb devices (mouse, stick, ...), 'hcd-*' is
> used for emulated usb host adapters (uhci, ehci, ...), 'host-*' is used
> for host device pass-through code.
Which are also devices, depending on your point of view :)
> 'dev-' isn't the greated pick as it is somewhat generic indeed. I've
> also considered 'emu-' (to contrast with host-*), but it has pretty much
> the same issue. Other suggestions?
Looks like all your dev- actually start with dev-usb-. If you drop the
dev- prefix and keep the other prefixes, you get the grouping you want.
Regardless, collecting the usb devices in one place is an improvement.
Let's do it.
[Qemu-devel] [RfC PATCH 2/2] usb: zap hw/ush-{ohic, uhci}.h + init wrappers, Gerd Hoffmann, 2012/03/08
Re: [Qemu-devel] [RfC PATCH 0/2] usb: reorganize source files., Andreas Färber, 2012/03/08
Re: [Qemu-devel] [RfC PATCH 0/2] usb: reorganize source files., Anthony Liguori, 2012/03/08