[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 05/11] Fix sign of sscanf format specifiers
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 05/11] Fix sign of sscanf format specifiers |
Date: |
Thu, 8 Mar 2012 15:37:15 +0000 |
From: Stefan Weil <address@hidden>
All values read by sscanf are unsigned, so replace %d by %u.
This signed / unsigned mismatch was detected by splint.
Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
cursor.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/cursor.c b/cursor.c
index efc5917..76e262c 100644
--- a/cursor.c
+++ b/cursor.c
@@ -15,7 +15,8 @@ static QEMUCursor *cursor_parse_xpm(const char *xpm[])
uint8_t idx;
/* parse header line: width, height, #colors, #chars */
- if (sscanf(xpm[line], "%d %d %d %d", &width, &height, &colors, &chars) !=
4) {
+ if (sscanf(xpm[line], "%u %u %u %u",
+ &width, &height, &colors, &chars) != 4) {
fprintf(stderr, "%s: header parse error: \"%s\"\n",
__FUNCTION__, xpm[line]);
return NULL;
--
1.7.9.1
- [Qemu-devel] [PULL v2 00/11] Trivial patches for 25 February to 7 March 2012, Stefan Hajnoczi, 2012/03/08
- [Qemu-devel] [PATCH 06/11] libcacard: Use format specifier %u instead of %d for unsigned values, Stefan Hajnoczi, 2012/03/08
- [Qemu-devel] [PATCH 08/11] Spelling fixes in comments (it's -> its), Stefan Hajnoczi, 2012/03/08
- [Qemu-devel] [PATCH 01/11] sh7750: Remove redundant 'struct' from MemoryRegionOps, Stefan Hajnoczi, 2012/03/08
- [Qemu-devel] [PATCH 05/11] Fix sign of sscanf format specifiers,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 09/11] libcacard: Spelling and grammar fixes in documentation, Stefan Hajnoczi, 2012/03/08
- [Qemu-devel] [PATCH 04/11] block/vmdk: Fix warning from splint (comparision of unsigned value), Stefan Hajnoczi, 2012/03/08
- [Qemu-devel] [PATCH 02/11] qom: Fix spelling in documentation, Stefan Hajnoczi, 2012/03/08
- [Qemu-devel] [PATCH 03/11] qmp: Fix spelling fourty -> forty, Stefan Hajnoczi, 2012/03/08
- [Qemu-devel] [PATCH 10/11] osdep: Remove local definition of macro offsetof, Stefan Hajnoczi, 2012/03/08
- [Qemu-devel] [PATCH 07/11] vnc: Add break statement, Stefan Hajnoczi, 2012/03/08
- [Qemu-devel] [PATCH 11/11] configure: Quote the configure args printed in config.log, Stefan Hajnoczi, 2012/03/08
- Re: [Qemu-devel] [PULL v2 00/11] Trivial patches for 25 February to 7 March 2012, Anthony Liguori, 2012/03/09