[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 5/9] net: refector tcp_*_start functions
From: |
Amos Kong |
Subject: |
[Qemu-devel] [PATCH v3 5/9] net: refector tcp_*_start functions |
Date: |
Wed, 07 Mar 2012 06:48:21 +0800 |
User-agent: |
StGit/0.15 |
There are some repeated code for tcp_server_start()
and tcp_client_start().
Signed-off-by: Amos Kong <address@hidden>
---
net.c | 83 ++++++++++++++++++++++++++++++++++++-----------------------------
1 files changed, 46 insertions(+), 37 deletions(-)
diff --git a/net.c b/net.c
index 9afb0d1..b05c881 100644
--- a/net.c
+++ b/net.c
@@ -99,38 +99,41 @@ static int get_str_sep(char *buf, int buf_size, const char
**pp, int sep)
return 0;
}
-int tcp_server_start(const char *str, int *fd)
+static int tcp_server_bind(int fd, struct sockaddr_in *saddr)
{
- int val, ret;
- struct sockaddr_in saddr;
+ int ret;
+ int val = 1;
- if (parse_host_port(&saddr, str) < 0) {
- error_report("invalid host/port combination: %s", str);
- return -EINVAL;
- }
+ /* allow fast reuse */
+ setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, (const char *)&val, sizeof(val));
- *fd = qemu_socket(PF_INET, SOCK_STREAM, 0);
- if (fd < 0) {
- perror("socket");
- return -1;
+ ret = bind(fd, (struct sockaddr *)saddr, sizeof(*saddr));
+
+ if (ret == -1) {
+ ret = -socket_error();
}
- socket_set_nonblock(*fd);
+ return ret;
- /* allow fast reuse */
- val = 1;
- setsockopt(*fd, SOL_SOCKET, SO_REUSEADDR, (const char *)&val, sizeof(val));
+}
+
+static int tcp_client_connect(int fd, struct sockaddr_in *saddr)
+{
+ int ret;
+
+ do {
+ ret = connect(fd, (struct sockaddr *)saddr, sizeof(*saddr));
+ if (ret == -1) {
+ ret = -socket_error();
+ }
+ } while (ret == -EINTR || ret == -EWOULDBLOCK);
- ret = bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr));
- if (ret < 0) {
- closesocket(*fd);
- }
return ret;
}
-int tcp_client_start(const char *str, int *fd)
+static int tcp_start_common(const char *str, int *fd, bool server)
{
+ int ret = -EINVAL;
struct sockaddr_in saddr;
- int ret;
*fd = -1;
if (parse_host_port(&saddr, str) < 0) {
@@ -145,29 +148,35 @@ int tcp_client_start(const char *str, int *fd)
}
socket_set_nonblock(*fd);
- for (;;) {
- ret = connect(*fd, (struct sockaddr *)&saddr, sizeof(saddr));
- if (ret < 0) {
- ret = -socket_error();
- if (ret == -EINPROGRESS) {
- break;
+ if (server) {
+ ret = tcp_server_bind(*fd, &saddr);
+ } else {
+ ret = tcp_client_connect(*fd, &saddr);
+ }
+
#ifdef _WIN32
- } else if (ret == -WSAEALREADY || ret == -WSAEINVAL) {
- break;
+ if (ret == -WSAEALREADY || ret == -WSAEINVAL) {
+ return ret; /* Success */
+ }
#endif
- } else if (ret != -EINTR && ret != -EWOULDBLOCK) {
- perror("connect");
- closesocket(*fd);
- return ret;
- }
- } else {
- break;
- }
+ if (ret >= 0 || ret == -EINPROGRESS || ret == -EWOULDBLOCK) {
+ return ret; /* Success */
}
+ closesocket(*fd);
return ret;
}
+int tcp_server_start(const char *str, int *fd)
+{
+ return tcp_start_common(str, fd, true);
+}
+
+int tcp_client_start(const char *str, int *fd)
+{
+ return tcp_start_common(str, fd, false);
+}
+
int parse_host_port(struct sockaddr_in *saddr, const char *str)
{
char buf[512];
- Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start(), (continued)
- [Qemu-devel] [PATCH v3 4/9] net: use tcp_client_start for tcp client creation, Amos Kong, 2012/03/06
- [Qemu-devel] [PATCH v3 6/9] net: use getaddrinfo() in tcp_start_common, Amos Kong, 2012/03/06
- [Qemu-devel] [PATCH v3 7/9] net: introduce parse_host_port_info(), Amos Kong, 2012/03/06
- [Qemu-devel] [PATCH v3 5/9] net: refector tcp_*_start functions,
Amos Kong <=
- [Qemu-devel] [PATCH v3 8/9] net: split hostname and service by last colon, Amos Kong, 2012/03/06
- [Qemu-devel] [PATCH v3 9/9] net: support to include ipv6 address by brackets, Amos Kong, 2012/03/06